fix(metric): Add VFP counter metric for uninitialized object #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Nov 7, 2024
matmerr
requested changes
Nov 18, 2024
matmerr
previously approved these changes
Nov 21, 2024
BeegiiK
force-pushed
the
issues/993
branch
5 times, most recently
from
171324f to
e0bb58a
Compare
kamilprz
previously approved these changes
Nov 22, 2024
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
github-actions
bot
removed
the
meta/waiting-for-author
kamilprz
approved these changes
Dec 31, 2024
|
|
||
| metrics.DropPacketsGauge.WithLabelValues(utils.Endpoint, egressLabel).Set(float64(stats.hnscounters.DroppedPacketsOutgoing)) | ||
| metrics.DropPacketsGauge.WithLabelValues(utils.Endpoint, ingressLabel).Set(float64(stats.hnscounters.DroppedPacketsIncoming)) | ||
|
|
||
| if stats.vfpCounters == nil { | ||
| h.l.Warn("will not record some metrics since VFP port counters failed to be set") | ||
| metrics.VfpStatsGauge.WithLabelValues(utils.Uninitialized).Inc() |
There was a problem hiding this comment.
This doesn't seem correct; what are you measuring here? Number of times we see no vfpcounters? Doesn't seem useful.
matmerr
requested changes
Jan 22, 2025
There was a problem hiding this comment.
let's park this for a moment, we need to quantify the value of new metrics that we're adding so they don't impact costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add node level metric for no VFPCounters. Tested the new metric works by calling the metrics endpoint inside the node of the windows retina pod:
Related Issue
#933
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
The metric was generated as it brought outside the conditional statement for testing purposes only, i.e. metric can be compiled and incremented.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.